blockmanager: remove block manager chain state. #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
requested changes
Sep 12, 2018
blockmanager.go
Outdated
| // Query the chain for the latest best block | ||
| // since the block that was processed could be | ||
| // on a side chain or have caused a reorg. | ||
| // Fetch the best block fom the state snapshot, the block processed |
There was a problem hiding this comment.
This comment isn't correct if you look just above, you can see that this case clearly only runs when the block extended the main chain.
dnldd
force-pushed
the
rm_chainstate
branch
2 times, most recently
from
d384cdf
to
f080ee3
Compare
This was referenced Sep 12, 2018
dnldd
force-pushed
the
rm_chainstate
branch
from
f080ee3
to
7b22549
Compare
davecgh
approved these changes
Sep 12, 2018
This was referenced Sep 12, 2018
JFixby
pushed a commit
to JFixby/dcrd
that referenced
this pull request
Sep 20, 2019
chaincfg: update checkpoints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires #1417, #1418 and #1419.
Port of upstream commit 2274d36 (subset).