indexers: Use testable bucket for existsaddrindex. #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
approved these changes
Sep 10, 2018
jrick
approved these changes
Sep 10, 2018
This modifies the functions in the exists address index to use the internalBucket interface instead of directly taking a database.Bucket interface. This allows tests to mock the data the source and is consistent with the address index.
davecgh
force-pushed
the
existsaddrindex_internal_bucket
branch
from
c00dcd5
to
830aa6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the functions in the exists address index to use the
internalBucketinterface instead of directly taking adatabase.Bucketinterface. This allows tests to mock the data the source and is consistent with the address index.