blockchain: Separate tx input stake checks. #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 14, 2018
dnldd
reviewed
Sep 14, 2018
alexlyp
approved these changes
Sep 14, 2018
davecgh
commented
Sep 14, 2018
This separates all of the validation checks in CheckTransactionInputs related to each allowed type of stake transaction into separate functions dedicated to each type. It also renames the utxo view parameter to CheckTransactionInputs to be consistent with the name used in other functions throughout the package. It does not perform any additional cleanup beyond the separation and does not have any functional changes.
davecgh
force-pushed
the
blockchain_separate_tx_input_stake_checks
branch
from
50731b9
to
7ae066f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates all of the validation checks in
CheckTransactionInputsrelated to each allowed type of stake transaction into separate functions dedicated to each type.It also renames the utxo view parameter to
CheckTransactionInputsto be consistent with the name used in other functions throughout the package.It does not perform any additional cleanup beyond the separation and does not have any functional changes.
This is work towards #1145.