-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Support MacOS sed for obtaining module list. #1483
Merged
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like an old version of gometalinter. |
sorted out and working as expected. |
dnldd
approved these changes
Oct 8, 2018
jrick
approved these changes
Oct 8, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't test on macOS but looks reasonable
This modifies the code in run_tests.sh which obtains the stripped list of modules to test based on the output of the go list command to work with MacOS as well. It seems that sed on MacOS does not like the "or" regexp syntax, so this modifies it to perform each branch separately.
davecgh
force-pushed
the
build_fix_macos_module_list
branch
from
October 8, 2018 17:32
e2c95bc
to
7e3dfb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the code in
run_tests.sh
which obtains the stripped list of modules to test based on the output of the go list command to work with MacOS as well. It seems thatsed
on MacOS does not like the "or" regexp syntax, so this modifies it to perform each branch separately.