chaingen: Only revoke missed tickets once. #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies the test chain generator infrastructure that automatically tracks missed votes and generates revocations for them to only generate a single revocation and properly handle reorgs by removing revoked tickets from the pool of missed tickets when a block is connected and adding back any revoked tickets to the pool of missed tickets when a block that contains them is disconnected. In addition, it modifies the handling of stake ticket purchases such that the associated ticket purchases are created after the munge functions run to ensure all changes are accurately account for. In particular, the indexes of the ticket purchase transactions within the block can change if the munger adds or removes transactions before them. This allows the large reorg tests to work as intended again.
jrick
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the test chain generator infrastructure that automatically tracks missed votes and generates revocations for them to only generate a single revocation and properly handle reorgs by removing revoked tickets from the pool of missed tickets when a block is connected and adding back any revoked tickets to the pool of missed tickets when a block that contains them is disconnected.
In addition, it modifies the handling of stake ticket purchases such that the associated ticket purchases are created after the munge functions run to ensure all changes are accurately account for. In particular, the indexes of the ticket purchase transactions within the block can change if the munger adds or removes transactions before them.
This allows the large reorg tests to work as intended again.