Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main: move cert tests to a separated file #1502

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Conversation

JFixby
Copy link
Contributor

@JFixby JFixby commented Oct 18, 2018

Move mistakenly gated cert tests to another file.

@davecgh
Copy link
Member

davecgh commented Oct 18, 2018

They weren't ignored. They were simply gated behind the rpctest build flag. I have no objection to the change, but the description is incorrect.

Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look fine. Please squash into a single commit.

@JFixby JFixby changed the title main: move cert tests to test file that is not ignored main: move cert tests to a file that is not gated behind the build flag Oct 18, 2018
@davecgh
Copy link
Member

davecgh commented Oct 18, 2018

Commit title does not follow contribution guidelines (too long).

@JFixby JFixby changed the title main: move cert tests to a file that is not gated behind the build flag main: move cert tests to a separated file Oct 18, 2018
@davecgh davecgh merged commit 4896240 into decred:master Oct 18, 2018
@JFixby JFixby deleted the certtest branch October 20, 2018 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants