Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main: move cert tests to a separated file #1502

Merged
merged 1 commit into from
Oct 18, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 79 additions & 0 deletions cert_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
// Copyright (c) 2018 The Decred developers
// Use of this source code is governed by an ISC
// license that can be found in the LICENSE file.

package main

import (
"crypto/x509"
"encoding/pem"
"io/ioutil"
"os"
"testing"
)

// TestCertCreationWithHosts creates a certificate pair with extra hosts and
// ensures the extra hosts are present in the generated files.
func TestCertCreationWithHosts(t *testing.T) {
certFile, err := ioutil.TempFile("", "certfile")
if err != nil {
t.Fatalf("Unable to create temp certfile: %s", err)
}
certFile.Close()
defer os.Remove(certFile.Name())

keyFile, err := ioutil.TempFile("", "keyfile")
if err != nil {
t.Fatalf("Unable to create temp keyfile: %s", err)
}
keyFile.Close()
defer os.Remove(keyFile.Name())

// Generate cert pair with extra hosts.
hostnames := []string{"hostname1", "hostname2"}
err = genCertPair(certFile.Name(), keyFile.Name(), hostnames)
if err != nil {
t.Fatalf("Certificate was not created correctly: %s", err)
}
certBytes, err := ioutil.ReadFile(certFile.Name())
if err != nil {
t.Fatalf("Unable to read the certfile: %s", err)
}
pemCert, _ := pem.Decode(certBytes)
x509Cert, err := x509.ParseCertificate(pemCert.Bytes)
if err != nil {
t.Fatalf("Unable to parse the certificate: %s", err)
}

// Ensure the specified extra hosts are present.
for _, host := range hostnames {
err := x509Cert.VerifyHostname(host)
if err != nil {
t.Fatalf("failed to verify extra host '%s'", host)
}
}
}

// TestCertCreationWithOutHosts ensures the creating a certificate pair without
// any hosts works as intended.
func TestCertCreationWithOutHosts(t *testing.T) {
certFile, err := ioutil.TempFile("", "certfile")
if err != nil {
t.Fatalf("Unable to create temp certfile: %s", err)
}
certFile.Close()
defer os.Remove(certFile.Name())

keyFile, err := ioutil.TempFile("", "keyfile")
if err != nil {
t.Fatalf("Unable to create temp keyfile: %s", err)
}
keyFile.Close()
defer os.Remove(keyFile.Name())

// Generate cert pair with no extra hosts.
err = genCertPair(certFile.Name(), keyFile.Name(), nil)
if err != nil {
t.Fatalf("Certificate was not created correctly: %s", err)
}
}
69 changes: 0 additions & 69 deletions rpcserver_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,7 @@ package main

import (
"bytes"
"crypto/x509"
"encoding/pem"
"fmt"
"io/ioutil"
"os"
"runtime/debug"
"testing"
Expand Down Expand Up @@ -167,69 +164,3 @@ func TestRpcServer(t *testing.T) {
currentTestNum++
}
}

// TestCertCreationWithHosts creates a certificate pair with extra hosts and
// ensures the extra hosts are present in the generated files.
func TestCertCreationWithHosts(t *testing.T) {
certFile, err := ioutil.TempFile("", "certfile")
if err != nil {
t.Fatalf("Unable to create temp certfile: %s", err)
}
certFile.Close()
defer os.Remove(certFile.Name())

keyFile, err := ioutil.TempFile("", "keyfile")
if err != nil {
t.Fatalf("Unable to create temp keyfile: %s", err)
}
keyFile.Close()
defer os.Remove(keyFile.Name())

// Generate cert pair with extra hosts.
hostnames := []string{"hostname1", "hostname2"}
err = genCertPair(certFile.Name(), keyFile.Name(), hostnames)
if err != nil {
t.Fatalf("Certificate was not created correctly: %s", err)
}
certBytes, err := ioutil.ReadFile(certFile.Name())
if err != nil {
t.Fatalf("Unable to read the certfile: %s", err)
}
pemCert, _ := pem.Decode(certBytes)
x509Cert, err := x509.ParseCertificate(pemCert.Bytes)
if err != nil {
t.Fatalf("Unable to parse the certificate: %s", err)
}

// Ensure the specified extra hosts are present.
for _, host := range hostnames {
err := x509Cert.VerifyHostname(host)
if err != nil {
t.Fatalf("failed to verify extra host '%s'", host)
}
}
}

// TestCertCreationWithOutHosts ensures the creating a certificate pair without
// any hosts works as intended.
func TestCertCreationWithOutHosts(t *testing.T) {
certFile, err := ioutil.TempFile("", "certfile")
if err != nil {
t.Fatalf("Unable to create temp certfile: %s", err)
}
certFile.Close()
defer os.Remove(certFile.Name())

keyFile, err := ioutil.TempFile("", "keyfile")
if err != nil {
t.Fatalf("Unable to create temp keyfile: %s", err)
}
keyFile.Close()
defer os.Remove(keyFile.Name())

// Generate cert pair with no extra hosts.
err = genCertPair(certFile.Name(), keyFile.Name(), nil)
if err != nil {
t.Fatalf("Certificate was not created correctly: %s", err)
}
}