-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi: Enable vote for DCP0004. #1579
Conversation
0e06e16
to
52b6680
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually verified voting process and deployment activation on simnet.
I should note that I also manually tested the deployment activation semantics on |
This implements the agenda for voting on the sequence lock fixes as defined in DCP0004 along with consensus tests and mempool acceptance tests to ensure its correctness. It also modifies the mempool to conditionally treat all transactions with enabled sequence locks as non standard until the vote passes at which point the will become standard with the modified semantics enforced. The following is an overview of the changes: - Generate new version blocks and reject old version blocks after a super majority has been reached - New block version on mainnet is version 6 - New block version on testnet is version 7 - Introduce a convenience function for determining if the vote passed and is now active - Enforce modified sequence lock semantics in accordance with the state of the vote - Modify the more strict standardness checks (acceptance to the mempool and relay) to enforce DCP0004 in accordance with the state of the vote - Make all transactions with enabled sequence locks non standard until the agenda vote passes - Add tests to ensure acceptance and relay behave according to the aforementioned description - Add tests for determining if the agenda is active for both mainnet and testnet - Add tests to ensure the corrected sequence locks are handled properly depending on the result of the vote
52b6680
to
4e8dc45
Compare
This requires PR #1578.
This implements the agenda for voting on the sequence lock fixes as defined in DCP0004 along with consensus tests and
mempool
acceptance tests to ensure its correctness.It also modifies the
mempool
to conditionally treat all transactions with enabled sequence locks as non standard until the vote passes at which point the will become standard with the modified semantics enforced.The following is an overview of the changes:
mainnet
is version 6testnet
is version 7mempool
and relay) to enforce DCP0004 in accordance with the state of the votemainnet
andtestnet