[release-v2.0] main: Use backported mixing updates. #3431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Immediately appending to a slice initialized with a non-zero length will lead to a slice which is twice as large as intended, with the initial half of the entries being left at their zero value. This is fixed by initializing the slice with **capacity** instead of length.
The submit queue channel was not actually increasing any performance. (*peer).submit() would synchronously wait for all error results, and the call to (*Wallet).SubmitMixMessage was already synchronized by the mixpool mutex. Furthermore, this also fixes a deadlock that was observed after a mixing wallet with the RPC syncer mode reconnected to a restarted dcrd. Pair request messages were being submitted onto the channel with the client mutex held in (*Client).Dicemix. However, handleSubmitQueue had already exited and the client had not yet been restarted after dcrd reconnect, and was unable to be started due to the locked mutex.
The client mutex was being held during the initial publishing of pair request messages to prevent a situation where a submit errored but the peer was still associated with the client, or the message was submitted to mixpool and sent to other peers but our local peer had not yet been associated to the client at the time an epoch tick occurred. This should not be a situation we will encounter anymore, since the PR submissions are spaced out intentionally to avoid sending them close to the epoch.
…ions The alternate session forming only incrementally removes PRs from the currently considered PR set. Even if a PR by a responsive peer is known, if it was removed due to not passing the majority checks earlier, it will never be used by our peers during this epoch. With that in mind, we should only use the most recent KEs with the lowest referenced PR counts when trying to form an alternate session, as the additional PRs from earlier KEs will never be reconsidered by that KE's identity.
This updates the 2.0 release branch to use the latest version of the mixing module which includes updates to improve session formation and increase performance. In particular, the following updated module version is used: - github.com/decred/dcrd/mixing@v0.4.1
jrick
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the 2.0 release branch to use the latest version of the
mixingmodule which includes updates to improve session formation and increase performance.In particular, the following updated module version is used:
Note that it also cherry picks all of the commits included in updates to the
mixingmodule to ensure they are also included in the release branch even though it is not strictly necessary sincego.modhas been updated to require the new release and thus will pull in the new code. However, from past experience, not having code backported to modules available in the release branch too leads to headaches for devs building from source in their local workspace with overrides such as those ingo.work.The mixing-related parts of the following PRs are included: