Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Babysit refund transactions. #3063

Open
JoeGruffins opened this issue Nov 8, 2024 · 3 comments · May be fixed by #3082
Open

core: Babysit refund transactions. #3063

JoeGruffins opened this issue Nov 8, 2024 · 3 comments · May be fixed by #3082
Assignees

Comments

@JoeGruffins
Copy link
Member

Core should treat refunds the same as redeems, not letting the trade complete until a refund has some number of confirmations and possibly sending new transactions if necessary, especially in the case of account based assets.

@buck54321
Copy link
Member

Oof. Quite the oversight. Let's prioritize this.

@JoeGruffins
Copy link
Member Author

I can work on this.

@buck54321 buck54321 assigned buck54321 and JoeGruffins and unassigned buck54321 Nov 11, 2024
@buck54321
Copy link
Member

Thanks, @JoeGruffins. To note, we monitor transactions for finality for EVM assets internally already, but not UTXO assets. This issue is about how core handles finality though. We should probably look closely at how we handle responsibility sharing in this area.

@JoeGruffins JoeGruffins linked a pull request Nov 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants