Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: funds are released with huge delay for failed-to-place trade #3152

Open
norwnd opened this issue Jan 19, 2025 · 1 comment
Open

core: funds are released with huge delay for failed-to-place trade #3152

norwnd opened this issue Jan 19, 2025 · 1 comment

Comments

@norwnd
Copy link
Contributor

norwnd commented Jan 19, 2025

When Client is unable to place a trade due to Server rejecting it, for example:

2025-01-19 14:07:09.195 [ERR] CORE: notify: |ERROR| (order) In-Flight Order Error - In-Flight order with ID 3 failed: new order request with DEX server dex.decred.org:7232 market dcr_btc failed: rpc error: error code 36: failed funding validation

Client funds are locked and only released on the next wallet balance update (BTC wallet in this case) which might happen tens of minutes later (eg. upon next BTC block being mined, or upon Bison wallet restart).

Instead funds should be released immediately.

The following change seems to be resolving this issue: norwnd@b985e49

notes:

  • it also should account for funds reserved for Redeems/Refunds
  • there is also minor refactoring in there for ErrorCloser to make the intentions around its usage explicit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@norwnd and others