client/webserver/site: skip redundant step during DEX trading account creation #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
buck54321
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed the first form displayed on the
registerpage when coming from themarketpage (i.e. after clicking on theCreate Accountbutton) is redundant, I think. ThediscoverAcctFormhas nothing on it except the password box. This diff removes this extra step for users by auto-proceeding to the next step if their pass is cached.The brief form display with the spinner is expected so as not to keep the user on a blank page if the requests take longer to complete.
This video shows the new changes:
Screen.Recording.2023-09-25.at.11.06.22.PM.mov