Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

searchrawtransactions: fix vinextra arg clobbering any following args #89

Merged
merged 1 commit into from
Sep 12, 2017

Conversation

chappjc
Copy link
Member

@chappjc chappjc commented Sep 8, 2017

A nil pointer value signals that nothing was input for the argument and any following arguments must be defaults. So if you want to set reverse=true and vinextra=false, you cannot do it.

@chappjc
Copy link
Member Author

chappjc commented Sep 11, 2017

To be more explicit:

includePrevOut, reverse := false, true
SearchRawTransactionsVerbose(address, 0, count, includePrevOut, reverse, nil)

Won't reverse because of includePrevOut being false and setting SearchRawTransactionsCmd.VinExtra to a nil pointer instead of a pointer to an int that equals 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants