Add expired tickets infrastructure #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tACK (what a challenge with 3 other PRs!) |
|
Though this should be ready to go, I still need to add expired to the pooltickets (which requires a db update in dcrwallet) Going to wait to merge until I can fully test with that |
|
Well this needs to be rebased obviously. Aside from that, decred/dcrwallet#371 needs to be decided/fixed/implemented before this can go in. |
|
Hmmm apparently my branch is lost to the ether, I'll close this and reopen one once the changes hit dcrwallet |
|
Weird, I cherry picked your commit long ago, just waiting for wallet to support it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still requires wallet PR to discern missed PoolTickets vs expired
Fixes #57