Add expired to getstakeinfo command #360
Conversation
| @@ -2825,6 +2825,7 @@ type StakeInfoData struct { | |||
| Voted uint32 | |||
| Missed uint32 | |||
| Revoked uint32 | |||
| Expired uint32 | |||
There was a problem hiding this comment.
Maybe need something around here too:
https://github.com/alexlyp/btcwallet/blob/c60d4e2133d4f02d581d9903219cdd6356fa928c/wallet/wallet.go#L2856
| } | ||
|
|
||
| // Check the expired ticket pool for the presense of tickets. | ||
| expiredBitSetBStr, err := chainClient.ExistsExpiredTickets(revokeTicketPtrs) |
There was a problem hiding this comment.
Then does chainClient.MissedTickets() no longer include expired? Or does that count need to be decremented?
There was a problem hiding this comment.
I guess that's a good point, I was using a inclusive/exclusive view of them. All expired are missed, but not all missed are expired.
There was a problem hiding this comment.
To me, missed implies someone wasn't listening and missed their opportunity.
There was a problem hiding this comment.
ya i agree with that. though not sure the current bucketing in dcrd. i believe missed is inclusive of expired, so you'd have to do the changes in wallet. i'm going to keep it for now but i'll open an issue that we can discuss/resolve this in the near future
|
tACK |
|
Is this going in? I'd like it. |
No description provided.