Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix old DB serialization code that caused panics. #696

Merged
merged 1 commit into from
Apr 29, 2017

Conversation

jrick
Copy link
Member

@jrick jrick commented Apr 28, 2017

Only attempt to read the extended votebits from a version <=2 DB
ticket purchase record when votebits were recorded. In very early
versions of the code, these fields were completely skipped over and
zeros were written in their place.

Fixes #384
Fixes #695

Only attempt to read the extended votebits from a version <=2 DB
ticket purchase record when votebits were recorded.  In very early
versions of the code, these fields were completely skipped over and
zeros were written in their place.
@jrick
Copy link
Member Author

jrick commented Apr 28, 2017

@meany give this a try

@meany
Copy link

meany commented Apr 29, 2017

@jrick, things look good. not sure if i can give you a log of it updating the information in the wallet about the old stake purchases but it did start. afterwards i was able to start version 1.0.1+release without issue

Copy link

@meany meany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works on old stake records correctly

Copy link
Member

@alexlyp alexlyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jrick jrick merged commit e6056ff into decred:master Apr 29, 2017
@jrick jrick deleted the screaminginternally branch April 29, 2017 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants