Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude expired tickets in missed count. #716

Merged
merged 1 commit into from
May 4, 2017
Merged

Conversation

jrick
Copy link
Member

@jrick jrick commented May 4, 2017

Closes #371.

@jolan
Copy link
Contributor

jolan commented May 4, 2017

I think #371 came about because stake pools were showing tickets as missed when they were really expired. So there are actually two related parts of this:

  1. getstakeinfo output
  2. stakepooluserinfo output

So this fixes 1 but not 2. Happy to open another issue if you don't want to address that now though.

@jrick
Copy link
Member Author

jrick commented May 4, 2017

I'm not following. The results of stakepooluserinfo don't include any missed/expired counts.

@jolan
Copy link
Contributor

jolan commented May 4, 2017

There's a status field:

    {
      "status": "missed",
      "ticket": "652ce98dc0f9528ccd1a073b00851dc97caddc43fe2a10e8a0fbfe53c03eadab",
      "ticketheight": 1609,
      "spentby": "7704180e26fe4cda79ebe79a8a882cc952fcb4bbea94cfb3cb7d7c57aad233fb",
      "spentbyheight": 7770
    },

Copy link
Contributor

@jolan jolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tOK

Will open a separate issue for stakepooluserinfo.

@jrick jrick merged commit fc91923 into decred:master May 4, 2017
@jrick jrick deleted the justmissed branch May 4, 2017 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants