Avoid address reuse after restarting. #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
force-pushed
the
persistence
branch
4 times, most recently
from
777b70d
to
681c8f1
Compare
This also includes the source code to generate the v4 database.
jrick
force-pushed
the
persistence
branch
2 times, most recently
from
62dd178
to
a3e0d75
Compare
A database upgrade has been added which records the last-returned child index of both the external and internal branches of each BIP0044 account. As addresses are generated, these child indexes are recorded in the database and read on the next application startup. New addresses created after restart use child indexes after the last returned index in order to prevent accidental address reuse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A database upgrade has been added which records the last-returned
child index of both the external and internal branches of each BIP0044
account. As addresses are generated, these child indexes are recorded
in the database and read on the next application startup. New
addresses created after restart use child indexes after the last
returned index in order to prevent accidental address reuse.
Fixes #799.