Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import to csv notification quoting fix #2395

Merged
merged 3 commits into from
Jan 24, 2020
Merged

Import to csv notification quoting fix #2395

merged 3 commits into from
Jan 24, 2020

Conversation

bgptr
Copy link
Collaborator

@bgptr bgptr commented Jan 16, 2020

closes #2356

matheusd
matheusd reviewed Jan 16, 2020
View reviewed changes
Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, this still doesn't solve it for me. I still see "Export of file ''{filename}'' completed!" in the snackbar.

I tried upgrading to the latest react-intl version, but even that doesn't really solve it.

Maybe we should cheat and switch to the corresponding unicode {left,right} single quotation marks (U+2018, U+2019)? That seems to do the trick.

@bgptr
Copy link
Collaborator Author

bgptr commented Jan 16, 2020

Interesting. I changed it to the unicode characters.

vctt94
vctt94 approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@vctt94 vctt94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me now

@vctt94
Copy link
Member

vctt94 commented Jan 16, 2020

Also, Matheus can correct me if I am wrong, but I believe there is no need to update original.json, as well.

@bgptr
Copy link
Collaborator Author

bgptr commented Jan 22, 2020

@vctt94 Sorry, I have reverted it.

@alexlyp alexlyp merged commit 9122252 into decred:master Jan 24, 2020
@vctt94 vctt94 mentioned this pull request Jan 27, 2020
Closed
alexlyp pushed a commit that referenced this pull request Jan 28, 2020
@bgptr @alexlyp
Import to csv notification quoting fix (#2395)
fbbf081
@bgptr bgptr deleted the export_notification_fix branch February 9, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vctt94 vctt94 vctt94 approved these changes

@matheusd matheusd matheusd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Transactions] Import to csv
4 participants
@bgptr @vctt94 @matheusd @alexlyp