Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: new accounts #125

Merged
merged 3 commits into from
Mar 19, 2020
Merged

ui: new accounts #125

merged 3 commits into from
Mar 19, 2020

Conversation

buck54321
Copy link
Member

Adds screens and forms necessary to create accounts. Modifies account screen to include basic send-to-address form and settings button. Account settings screen has a single form for renaming the account. A few other tweaks.

image

image

@@ -868,6 +870,7 @@ def blob(acct):
"""Satisfies the encode.Blobber API"""
return (
BuildyBytes(0)
.addData(encode.intToBytes(acct.idx))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified the encoding without updating the version. Sync from mnemonic seed. I am planning on stopping doing this soon, maybe after we resolve #102.

Comment on lines -1960 to +1967
stakePool.getPurchaseInfo()
stakePool.authorize(self.votingAddress().string())
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoeGruffins I didn't see any problem calling authorize here instead of below. authorize calls purchaseInfo internally. Is this OK?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Comment on lines +420 to +421
self.addrSubscribers = {}
self.blockSubscribers = []
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different receivers for different addresses allows the DcrdataBlockchain to be reused by different accounts.

@@ -0,0 +1,63 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a backup file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops.

Copy link
Member

@JoeGruffins JoeGruffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exception when creating a new account:

  File "/home/joe/git/tinydecred/tinywallet/tinywallet/screens.py", line 1191, in createAcctPW
    cryptoKey = app.wallet.cryptoKey(pw)
  File "/home/joe/git/tinydecred/decred/decred/wallet/wallet.py", line 140, in cryptoKey
    pwKey = crypto.SecretKey.rekey(password.encode(), self.keyParams)
  File "/home/joe/git/tinydecred/decred/decred/crypto/crypto.py", line 1205, in rekey
    raise DecredError("rekey digest check failed")
2020-03-19 09:47:29,377 screens WARNING createAcctPW(1194) exception encountered while decoding wallet key: rekey digest check failed

@buck54321
Copy link
Member Author

I usually only see that when I've flubbed a password somewhere. Have you tried again? And just to be sure, did you delete you're old database?

@JoeGruffins
Copy link
Member

it was the password, srry bout that

Copy link
Member

@JoeGruffins JoeGruffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great.

Comment on lines -1960 to +1967
stakePool.getPurchaseInfo()
stakePool.authorize(self.votingAddress().string())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Adds screens and forms necessary to create accounts. Modifies
account screen to include basic send-to-address form and settings
button. Account settings screen has a single form for renaming the
account. A number of general layout tweaks.
@buck54321 buck54321 merged commit 3026951 into decred:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants