-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi: remove indentation tabs #20
Conversation
Thanks for waiting, @teknico. Rebase when you get a chance. |
Done, all tests still pass using both |
I got slightly different results with black: Was this done with flake8 or something else? BY HAND!??!$%#$ Yours has removed almost all of the tab errors, but I still see four in app.py
|
Black is not the right tool for this job because it does not remove all the tabs, and it also makes other changes that I didn't want; this PR is too large already.
Which style changes to make, according to which tool, and how to configure it is best handled in another PR.
Flake8 only points out problems, it does not fix them. And well, not entirely by hand. 😉 The Midnight Commander editor usefully highlights tabs and trailing blanks: I used it to search and replace tabs in each file that had them, then used Sublime Text 3 only on those files to remove trailing blanks.
Good catch, thanks, fixing those too. |
Also remove trailing whitespace and add empty lines at EOF, but only from the files that had tabs removed anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
Also remove trailing whitespace and add/remove empty lines at EOF, but only from files that had tabs removed anyway. Fixes #19.
Only whitespace changes intended, hopefully it's not breaking anything.
Sorry for the large diff, feel free to merge #7 and #18 first and I’ll rebase on top of their commits.