Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] No verification that only organizer can create/open/close rollcall #1777

Closed
2 of 6 tasks
arnauds5 opened this issue Mar 13, 2024 · 0 comments · Fixed by #1778
Closed
2 of 6 tasks

[BUG] No verification that only organizer can create/open/close rollcall #1777

arnauds5 opened this issue Mar 13, 2024 · 0 comments · Fixed by #1778
Assignees
Labels
be1-go bug Something isn't working

Comments

@arnauds5
Copy link
Collaborator

Description (Actual behavior)

On the be1-go backend, there is no verification that only organizer can create/open/close a rollcall.
Anyone can send theses messages (using a modified frontend) and the go backend will accept them.

Expected behavior

There should have a verification of the public key and deny any rollcall create/open/close if not from an organizer.

How to reproduce

  1. Create a Lao with client1 (organizer)
  2. Join the Lao with client2 (with a modified frontend that allow sending the messages)
  3. Create/open/close a Rollcall with client2
  4. See no error (expected to fail)

Version & Environment

This bug was reproduced on:

Front-ends:
  • Fe1-Web (please include browser's names & version)
  • Fe2-Android (please specify if phone or emulation, and Android version)
  • Not applicable
Back-ends:
  • Be1-Go
  • Be2-Scala
  • Not applicable
Environment (as applicable):

Workaround

The scala backend doesn't seem to be vulnerable to the same problem.

Impact

Anyone can maliciously create a new rollcall and add many PoP token.

Possible root cause

No verification that the sender of a rollcall create/open/close is the organizer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
be1-go bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant