Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make []string slice 'blacklist' thread-safe #1754

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

emonnin-epfl
Copy link
Contributor

Addresses the issue #1747

The []string slice 'blacklist' should now be thread-safe.

@emonnin-epfl emonnin-epfl self-assigned this Feb 24, 2024
@emonnin-epfl emonnin-epfl requested a review from a team as a code owner February 24, 2024 14:58
@CLAassistant
Copy link

CLAassistant commented Feb 24, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
pierluca
🥇
5
▀▀▀▀▀▀
6d 7h 35m
▀▀▀▀▀▀
10
▀▀▀▀▀▀▀▀▀▀
jbsv
🥈
2
▀▀
1d 7h 33m
0
MariemBaccari
🥉
1
3d 54m
▀▀▀
0
K1li4nL
1
18m
0

Copy link

sonarcloud bot commented Feb 24, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 24, 2024

Copy link

sonarcloud bot commented Feb 24, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 24, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 24, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe1-Web'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sgueissa sgueissa linked an issue Feb 24, 2024 that may be closed by this pull request
6 tasks
@sgueissa sgueissa added be1-go bug-fix Fixes a bug labels Feb 24, 2024
Copy link
Collaborator

@sgueissa sgueissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good just some minor things to change

Copy link
Contributor

@MariemBaccari MariemBaccari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job !

@emonnin-epfl emonnin-epfl merged commit e927a9f into master Feb 26, 2024
19 checks passed
@emonnin-epfl emonnin-epfl deleted the work-be1-emonnin-epfl-threadsafe-hub-blacklist branch February 26, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hub blacklist is not thread safe
4 participants