Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[be1] add federation result handling #1841

Conversation

1florentin
Copy link
Contributor

@1florentin 1florentin commented May 1, 2024

This PR adds handling of the federation result message.

Also it modifies the already existing handling of the federation init message, to forward the challenge to the remote server.

@1florentin 1florentin requested a review from arnauds5 May 1, 2024 15:17
@1florentin 1florentin self-assigned this May 1, 2024
Copy link

github-actions bot commented May 1, 2024

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇
6
▀▀
4d 22h 16m
25
▀▀▀▀
matteosz
🥈
5
▀▀
5d 4h 55m
9
▀▀
arnauds5
🥉
3
18h 51m
4
onsriahi14
3
2d 14h 7m
1
t1b00
2
7d 16h 20m
4
MariemBaccari
2
1d 5h 39m
0
ljankoschek
2
18m
0
simone-kalbermatter
2
1d 14h 29m
2
quadcopterman
2
12d 2h 43m
▀▀
1
Tyratox
1
4d 1h 48m
3
1florentin
1
2h 20m
0
sgueissa
1
25m
0
DanielTavaresA
1
3d 22h 24m
2
Kaz-ookid
1
15d 41m
▀▀▀
5
⚡️ Pull request stats

@K1li4nL K1li4nL added the be1-go label May 2, 2024
@1florentin 1florentin marked this pull request as ready for review May 5, 2024 16:00
@1florentin 1florentin requested a review from a team as a code owner May 5, 2024 16:00
be1-go/channel/federation/federation.go Outdated Show resolved Hide resolved
be1-go/channel/federation/federation.go Outdated Show resolved Hide resolved
be1-go/channel/federation/federation.go Outdated Show resolved Hide resolved
be1-go/channel/federation/federation.go Show resolved Hide resolved
be1-go/channel/federation/federation.go Outdated Show resolved Hide resolved
1florentin and others added 2 commits May 13, 2024 11:59
Co-authored-by: Arnaud S5 <arnauds5@users.noreply.github.com>
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Failed Quality Gate failed for 'PoP - Be1-Go'

Failed conditions
44.4% Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe1-Web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@1florentin 1florentin merged commit f190fb3 into work-be1-arnauds5-federation-authentication_a May 13, 2024
17 of 18 checks passed
@1florentin 1florentin deleted the work-be1-1florentin-federation_auth_protocol branch May 13, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants