New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1775 Digital Cash Warning: RollCallId not defined #1856

Merged

4xiom5 merged 3 commits into master from work-fe1-4xiom5-fix-digital-cash-warning

May 14, 2024

Contributor

4xiom5 commented May 14, 2024

The warning toast 'RollcallId not defined, cannot generate PoP token' was showing up at unecesserary times.
Explanation of the bug:

When using coin issuance (i.e isCoinbase is true) the parameter rollCallId is undefined which is expected.
In other cases: the hook useRollCallTokenByRollCallId is not synchronous and returns undefined for a few cycles causing encodePopToken to throw an error and serializedPopToken to be null even though rollCallId is well defined.

4xiom5 added 3 commits

May 14, 2024 17:52


          Fix error toast digital coin coinbase

57cd509


          Fix toast digital cash when roll call id defined

35b684b


          Update toast condition

6905be2

4xiom5 requested a review from a team as a code owner

May 14, 2024 16:25

4xiom5 self-assigned this

github-actions bot commented May 14, 2024

Pull reviewers stats

Stats of the last 30 days for popstellar:

	User	Total reviews	Time to review	Total comments
	K1li4nL 🥇	9 ▀▀	7d 4h 43m	26 ▀▀
	arnauds5 🥈	6 ▀	7d 5h 54m	22 ▀▀
	pierluca 🥉	5 ▀	12d 16h 52m ▀	15 ▀
	simone-kalbermatter	4 ▀	1d 14h 46m	2
	matteosz	4 ▀	2d 16h 40m	2
	t1b00	3 ▀	9d 4h 55m ▀	5
	MariemBaccari	3 ▀	25d 16h 55m ▀▀	11 ▀
	onsriahi14	3 ▀	18h 39m	6
	DanielTavaresA	3 ▀	12d 11h 11m ▀	12 ▀
	Tyratox	2	15d 15m ▀	19 ▀
	1florentin	2	8d 13h 48m ▀	6
	ljankoschek	2	18m	0
	quadcopterman	2	3d 22h 58m	0
	Kaz-ookid	2	15d 1h 34m ▀	6
	4xiom5	1	12d 4h 52m ▀	0
	sgueissa	1	25m	0
	osm-alt	1	7d 20h 33m	12 ▀
	emonnin-epfl	1	25d 21h 8m ▀▀	2
^{⚡️ Pull request stats}

4xiom5 requested a review from osm-alt

May 14, 2024 16:26

4xiom5 linked an issue

that may be closed by this pull request

Digital Cash Warning: RollCallId not defined #1775

Closed

sonarcloud bot commented May 14, 2024

Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarcloud bot commented May 14, 2024

Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarcloud bot commented May 14, 2024

Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarcloud bot commented May 14, 2024

Quality Gate passed for 'PoP - Fe1-Web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud bot commented May 14, 2024

Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

osm-alt approved these changes

View reviewed changes

Contributor

osm-alt left a comment

Looks good to me

4xiom5 requested a review from Tyratox

May 14, 2024 16:55

Tyratox approved these changes

View reviewed changes

4xiom5 added this pull request to the merge queue

Merged via the queue into master with commit 5b6c4d7

19 checks passed

4xiom5 deleted the work-fe1-4xiom5-fix-digital-cash-warning branch

May 14, 2024 17:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet