Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed wrong title for Digital Cash tab #1868

Merged

Conversation

Kaz-ookid
Copy link
Contributor

@Kaz-ookid Kaz-ookid commented May 16, 2024

addressing #1867

image

@Kaz-ookid Kaz-ookid requested a review from a team as a code owner May 16, 2024 13:20
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇
9
▀▀
7d 12h 8m
26
pierluca
🥈
6
13d 6h 39m
39
▀▀
arnauds5
🥉
6
7d 5h 54m
22
Tyratox
4
14d 6h 12m
42
▀▀
quadcopterman
4
5d 19h 9m
1
t1b00
3
9d 4h 55m
5
MariemBaccari
3
26d 2h 39m
▀▀
11
simone-kalbermatter
3
1d 14h 46m
0
onsriahi14
3
18h 39m
6
matteosz
3
4d 1h 8m
5
DanielTavaresA
3
8d 4h 48m
13
Kaz-ookid
3
14d 4h 30m
8
1florentin
2
8d 13h 48m
6
osm-alt
2
6d 22h 53m
12
ljankoschek
2
18m
0
4xiom5
1
12d 4h 52m
0
emonnin-epfl
1
25d 21h 8m
▀▀
2
⚡️ Pull request stats

@Kaz-ookid Kaz-ookid linked an issue May 16, 2024 that may be closed by this pull request
@Kaz-ookid Kaz-ookid self-assigned this May 16, 2024
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe1-Web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@simone-kalbermatter simone-kalbermatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simone-kalbermatter simone-kalbermatter added this pull request to the merge queue May 16, 2024
Merged via the queue into master with commit c70add9 May 16, 2024
19 checks passed
@simone-kalbermatter simone-kalbermatter deleted the work-fe2-maxime-fix-digitalcash-tab-title branch May 16, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Digital Cash Tab Title Is "Home" but Should Be "Digital Cash"
2 participants