[BE2] Work on more rules for linter #1871

t1b00 · 2024-05-17T13:16:22Z

Newly implemented rules:

IllegalFormatString
IncorrectNumberOfArgs
IncorrectlyNamedExceptions
LonelySealedTrait
MapGetAndGetOrElse
NanComparison
OptionSize
OptionGet
StripMarginOnregex
TryGet

Improved rules

EmptyInterpolatedString now supports literal.format() warning

Added Util file for utility methods (finding type, finding declarations...)

Task list: https://docs.google.com/spreadsheets/d/1LjsvOvH56TTYzyhhRpGPTqyeaSzew-pMDEPzRPVO3tE/edit?usp=sharing

…and created Util file with util functions

…rk-be2-thibault-linter_master

…) in EmptyInterpolatedString

github-actions · 2024-05-17T13:16:36Z

Pull reviewers stats

Stats of the last 30 days for popstellar:

	User	Total reviews	Time to review	Total comments
	K1li4nL 🥇	10 ▀▀	5d 23h 55m	32 ▀▀
	pierluca 🥈	6 ▀	13d 6h 39m ▀	39 ▀▀
	arnauds5 🥉	6 ▀	7d 5h 54m	22 ▀
	Tyratox	4 ▀	14d 6h 12m ▀	42 ▀▀
	simone-kalbermatter	4 ▀	1d 7h 51m	0
	quadcopterman	4 ▀	5d 19h 9m	1
	t1b00	3 ▀	9d 4h 55m ▀	5
	MariemBaccari	3 ▀	26d 2h 39m ▀▀	11 ▀
	onsriahi14	3 ▀	18h 39m	6
	matteosz	3 ▀	4d 1h 8m	5
	DanielTavaresA	3 ▀	5d 13m	13 ▀
	Kaz-ookid	3 ▀	14d 4h 30m ▀	8
	1florentin	2	8d 13h 48m ▀	6
	osm-alt	2	6d 22h 53m	12 ▀
	ljankoschek	2	18m	0
	4xiom5	1	12d 4h 52m ▀	0
	emonnin-epfl	1	25d 21h 8m ▀▀	2
^{⚡️ Pull request stats}

…nverted nested methods to private class methods)

… into work-be2-thibault-linter_master # Conflicts: # be2-scala/linter/input/src/main/scala/fix/LonelySealedTrait.scala

Corrected functionality in findDefinition (could previously only find literal definitions). Adapted other rules (IncorrectNumberOfArgsToFormat, IllegalFormatString) to modification

Adapted IllegalFormatString and NanComparison to modification in findDefinitions in Util

Improved Util with a matchType function and adapted matching

sonarcloud · 2024-05-30T09:29:10Z

Quality Gate passed for 'PoP - Fe1-Web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

DanielTavaresA

Overall good code. Couple of comments. If I could suggest an improvement it would be to add more documentation/comment in your code. Lint code is not trivial for persons for the outside and it can be hard to understand what is being done. In particular I think having a small comment on case saying what it is matching would improve greatly readability.

be2-scala/linter/rules/src/main/scala/fix/NanComparison.scala

be2-scala/linter/input/src/main/scala/fix/StripMarginOnRegex.scala

sonarcloud · 2024-06-05T08:12:16Z

Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarcloud · 2024-06-05T08:14:57Z

Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarcloud · 2024-06-05T08:15:15Z

Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarcloud · 2024-06-05T08:20:13Z

Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

K1li4nL

Really a non-expert eye here, your code looks good to me, the tests make sense so I will trust that, good job !

DanielTavaresA

Most important comments addressed. LGTM

t1b00 added 4 commits May 10, 2024 10:17

Work on more rules

93e4776

Built IllegalFormatString rule (still some input values left to add) …

4f0121b

…and created Util file with util functions

Merge branch 'refs/heads/work-be2-thibault-linter_more_rules' into wo…

3c4317a

…rk-be2-thibault-linter_master

Added tests in format string rules, added support for literal.format(…

b4dbf95

…) in EmptyInterpolatedString

t1b00 added the be2-scala label May 17, 2024

t1b00 self-assigned this May 17, 2024

t1b00 added 12 commits May 17, 2024 16:29

Added IncorrectNumberOfArgsToFormat rule, reformatted other rules (co…

ecfda68

…nverted nested methods to private class methods)

Added IncorrectNumberOfArgsToFormat rule, reformatted other rules (co…

2d3de5e

…nverted nested methods to private class methods)

Implemented IncorrectlyNamedExceptions

dc9cf71

Simplified test

8c562cb

Cleaned-up code

a495c08

Implemented LonelySealedTrait

e6b67f9

Implemented LonelySealedTrait

80c99a7

Merge remote-tracking branch 'origin/work-be2-thibault-linter_master'…

6999a27

… into work-be2-thibault-linter_master # Conflicts: # be2-scala/linter/input/src/main/scala/fix/LonelySealedTrait.scala

Added comments

0680e5f

Added MapGetAndGetOrElse

d5f9381

Added NanComparison rule

65c12bf

Corrected functionality in findDefinition (could previously only find literal definitions). Adapted other rules (IncorrectNumberOfArgsToFormat, IllegalFormatString) to modification

Removed useless code in IncorrectNumberOfArgsToFormat

ecbe196

t1b00 changed the title ~~Work on more rules for linter~~ [BE2] Work on more rules for linter May 29, 2024

t1b00 added 6 commits May 29, 2024 11:26

Added OptionGet and OptionSize

e4aa58b

Added StripMarginOnRegex rule

cf66a86

Adapted IllegalFormatString and NanComparison to modification in findDefinitions in Util

Removed unecessary println

70a9eb5

Simplified code for StripMarginOnRegex

10add0c

Added TryGet rule

3681835

Improved Util with a matchType function and adapted matching

Fixed wrong diag

39dfad3

Made getType null safe

a836771

t1b00 marked this pull request as ready for review June 3, 2024 12:21

t1b00 requested a review from a team as a code owner June 3, 2024 12:21

t1b00 requested review from onsriahi14, K1li4nL and DanielTavaresA June 3, 2024 12:22

DanielTavaresA requested changes Jun 4, 2024

View reviewed changes

be2-scala/linter/rules/src/main/scala/fix/NanComparison.scala Outdated Show resolved Hide resolved

be2-scala/linter/input/src/main/scala/fix/StripMarginOnRegex.scala Outdated Show resolved Hide resolved

t1b00 added 2 commits June 4, 2024 10:46

Uncommented code

4eb6797

Added .equals() support in NanComparison

9c32274

t1b00 requested a review from DanielTavaresA June 6, 2024 19:14

K1li4nL approved these changes Jun 7, 2024

View reviewed changes

DanielTavaresA approved these changes Jun 17, 2024

View reviewed changes

t1b00 added this pull request to the merge queue Jun 17, 2024

t1b00 merged commit 62b1a2e into master Jun 17, 2024
17 checks passed

t1b00 deleted the work-be2-thibault-linter_master branch June 17, 2024 12:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BE2] Work on more rules for linter #1871

[BE2] Work on more rules for linter #1871

t1b00 commented May 17, 2024 •

edited

Loading

github-actions bot commented May 17, 2024

sonarcloud bot commented May 30, 2024

DanielTavaresA left a comment

sonarcloud bot commented Jun 5, 2024

sonarcloud bot commented Jun 5, 2024

sonarcloud bot commented Jun 5, 2024

sonarcloud bot commented Jun 5, 2024

K1li4nL left a comment

DanielTavaresA left a comment

[BE2] Work on more rules for linter #1871

[BE2] Work on more rules for linter #1871

Conversation

t1b00 commented May 17, 2024 • edited Loading

github-actions bot commented May 17, 2024

Pull reviewers stats

sonarcloud bot commented May 30, 2024

Quality Gate passed for 'PoP - Fe1-Web'

DanielTavaresA left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Jun 5, 2024

Quality Gate passed for 'PoP - PoPCHA-Web-Client'

sonarcloud bot commented Jun 5, 2024

Quality Gate passed for 'PoP - Be2-Scala'

sonarcloud bot commented Jun 5, 2024

Quality Gate passed for 'PoP - Be1-Go'

sonarcloud bot commented Jun 5, 2024

Quality Gate passed for 'PoP - Fe2-Android'

K1li4nL left a comment

Choose a reason for hiding this comment

DanielTavaresA left a comment

Choose a reason for hiding this comment

t1b00 commented May 17, 2024 •

edited

Loading