Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New messages for pull rumors #1877

Merged
merged 15 commits into from
May 27, 2024
Merged

New messages for pull rumors #1877

merged 15 commits into from
May 27, 2024

Conversation

DanielTavaresA
Copy link
Collaborator

To be able to use pull gossiping, we need new messages that will share the state of the received rumors per server.

@github-actions GitHub Actions
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇		 10
▀▀		 5d 23h 55m
 32
▀▀
pierluca
🥈		 6
▀		 13d 6h 39m
▀		 39
▀▀
arnauds5
🥉		 6
▀		 7d 5h 54m
 22
▀
Tyratox
 4
▀		 14d 6h 12m
▀		 42
▀▀
simone-kalbermatter
 4
▀		 1d 7h 51m
 0
quadcopterman
 4
▀		 5d 19h 9m
 1
t1b00
 3
▀		 9d 4h 55m
▀		 5
MariemBaccari
 3
▀		 26d 2h 39m
▀▀		 11
▀
onsriahi14
 3
▀		 18h 39m
 6
matteosz
 3
▀		 4d 1h 8m
 5
DanielTavaresA
 3
▀		 5d 13m
 13
▀
Kaz-ookid
 3
▀		 14d 4h 30m
▀		 8
1florentin
 2
 8d 13h 48m
▀		 6
osm-alt
 2
 6d 22h 53m
 12
▀
ljankoschek
 2
 18m
 0
4xiom5
 1
 12d 4h 52m
▀		 0
emonnin-epfl
 1
 25d 21h 8m
▀▀		 2
⚡️ Pull request stats

@matteosz matteosz added the proto-spec Everything related to the PoP protocol label May 17, 2024
sgueissa
sgueissa reviewed May 20, 2024
View reviewed changes
Copy link
Collaborator

@sgueissa sgueissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great I would just suggest changing the name of the param to just state

protocol/query/method/rumor_state.json Outdated
"type": "object",
"additionalProperties": false,
"properties": {
"rumor_state": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could just write state, we already know it is a rumor_state with the method

@DanielTavaresA DanielTavaresA marked this pull request as ready for review May 22, 2024 17:14
@DanielTavaresA DanielTavaresA requested a review from a team as a code owner May 22, 2024 17:14
@DanielTavaresA DanielTavaresA mentioned this pull request May 25, 2024
Merged
@DanielTavaresA DanielTavaresA mentioned this pull request May 27, 2024
Merged
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe1-Web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sgueissa
sgueissa approved these changes May 27, 2024
View reviewed changes
Copy link
Collaborator

@sgueissa sgueissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good for me now with the added answer

K1li4nL
K1li4nL approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@K1li4nL K1li4nL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving blindly

@K1li4nL K1li4nL added this pull request to the merge queue May 27, 2024
Merged via the queue into master with commit fee60ae May 27, 2024
18 checks passed
@K1li4nL K1li4nL deleted the work-protocol-pull-rumor branch May 27, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgueissa sgueissa sgueissa approved these changes

@K1li4nL K1li4nL K1li4nL approved these changes

@emonnin-epfl emonnin-epfl Awaiting requested review from emonnin-epfl

Assignees
No one assigned
Labels
proto-spec Everything related to the PoP protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DanielTavaresA @sgueissa @K1li4nL @matteosz