[BE2] Added RumorStateAns to possible values of response #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull reviewers statsStats of the last 30 days for popstellar:
|
|
|
|
|
|
K1li4nL
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending on #1877
Added the possibility to have a list of rumors in the response. Some refactoring was needed because Scala do not see two List[A] and List[B] as different types. For that I added a new sealed trait ResultTypes that represents all possible ResultTypes. With this structure it is more manageable for future additions is more intuitive with a ResultObject having only one result and not one result for each possible type. ResultEmptyList is a "dirtyfix". It is necessary because for jsonRPC coming in, if list is empty it is impossible to differentiate a List[Rumor] or List[Message]. ResultEmptyList is a handled in a way that it returns a emptyList for both List[Rumor] and List[Message]. Such behaviour si not a real problem because there using jsonRPC id should avoid any conflict.