Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE1] Add publish test #1929

Merged

Conversation

sgueissa
Copy link
Collaborator

In this PR, I added one unit test for the publish method.

@sgueissa sgueissa requested a review from a team as a code owner June 13, 2024 16:01
@sgueissa sgueissa self-assigned this Jun 13, 2024
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇
18
▀▀▀▀
3d 20h 55m
14
▀▀▀
onsriahi14
🥈
4
1d 10h 51m
5
matteosz
🥉
4
21h 47m
3
arnauds5
3
2d 22h 36m
2
simone-kalbermatter
3
1h 47m
0
emonnin-epfl
3
8h 20m
8
▀▀
pierluca
2
3d 11h 3m
1
MariemBaccari
2
22h 39m
6
DanielTavaresA
2
9d 21h 46m
▀▀▀
2
Tyratox
1
44m
0
sgueissa
1
6d 11h 44m
▀▀
1
osm-alt
1
25m
0
Kaz-ookid
1
1d 2h 1m
5
⚡️ Pull request stats

Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

// succeed handling the publish but no notify rumor

messageHandler.On("Handle", channelPath, msg, false).Return(nil).Once()
db.On("AddMessageToMyRumor", msg.MessageID).Return(thresholdMessagesByRumor-1, nil).Once()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default, doesn't Mockery expect only one call?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got some problem using mockery without the .Once() so now I'm always using it

@sgueissa sgueissa merged commit 61aa18f into work-be1-stuart-replace-some-switch Jun 14, 2024
18 checks passed
@sgueissa sgueissa deleted the work-be1-stuart-add-publish-test branch June 14, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants