Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rumor process order #1964

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Fix rumor process order #1964

merged 3 commits into from
Jun 28, 2024

Conversation

DanielTavaresA
Copy link
Collaborator

Before, a rumor would be refused is unprocessable. Now even if we cannot process it (because not for us or another reason), it is written in memory allowing for following rumors to be processed

@DanielTavaresA DanielTavaresA requested a review from a team as a code owner June 28, 2024 13:18
@github-actions GitHub Actions
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇		 25
▀▀▀▀		 1d 19h 11m
 12
▀▀
matteosz
🥈		 8
▀		 3d 16h 5m
▀		 21
▀▀▀
arnauds5
🥉		 7
▀		 4h 29m
 4
▀
emonnin-epfl
 6
▀		 8h 20m
 8
▀
sgueissa
 4
▀		 1h 25m
 7
▀
quadcopterman
 3
 10d 7h 3m
▀▀▀		 1
1florentin
 2
 10d 5h 50m
▀▀▀		 0
MariemBaccari
 2
 22h 39m
 6
▀
simone-kalbermatter
 2
 5h 32m
 0
onsriahi14
 2
 6d 4h 27m
▀▀		 4
▀
Kaz-ookid
 2
 2d 4h 12m
▀		 9
▀
⚡️ Pull request stats

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 28, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 28, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 28, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 28, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

K1li4nL
K1li4nL reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@K1li4nL K1li4nL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about one change otherwise lgtm

be2-scala/src/main/resources/logback.xml
Comment on lines 3 to 20
<configuration debug="false" scan="true" scanPeriod="15 seconds">
<akkaProperty name="AKKA_LOGLEVEL" path="akka.loglevel" />
<appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
<encoder>
<pattern>%d{HH:mm:ss.SSS} - %highlight(%-5level) : %logger{0} > %msg%n</pattern>
</encoder>
</appender>

<logger name="ch.epfl.pop" level="INFO" additivity="false">
<appender-ref ref="STDOUT" />
</logger>

<!--Set root(general) logs level to INFO/DEBUG on STDOUT-->
<root level="INFO">
<appender-ref ref="STDOUT"/>
</root>

</configuration>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes wanted ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solved in DM: This is solving an issue where the "DEBUG" level would also apply to the dependencies as well making the logs quite cluttered.

@K1li4nL K1li4nL added this pull request to the merge queue Jun 28, 2024
Merged via the queue into master with commit 4b7ef79 Jun 28, 2024
18 checks passed
@K1li4nL K1li4nL deleted the fix-be2-daniel-rumor-process-order branch June 28, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onsriahi14 onsriahi14 onsriahi14 approved these changes

@K1li4nL K1li4nL K1li4nL approved these changes

Assignees
No one assigned
Labels
be2-scala
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielTavaresA @onsriahi14 @K1li4nL