Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/docs does not work with asyncapi 2.2.0 #109

Closed
alex-zywicki opened this issue Oct 25, 2021 · 1 comment
Closed

/docs does not work with asyncapi 2.2.0 #109

alex-zywicki opened this issue Oct 25, 2021 · 1 comment

Comments

@alex-zywicki
Copy link
Contributor

Hi @dedoussis

Screen Shot 2021-10-25 at 12 06 36 PM
When running the example on the current master branch, the error Error: Version 2.2.0 is not supported. is presented.

According to this issue Version 2.2.0 should be support on the next branch of asyncapi-react.
It appears you are using version 1.0.0-next.18.
There is now a 1.0.0-next.21 available, perhaps a version bump is needed?

@dedoussis
Copy link
Owner

Thanks a lot for spotting the issue as well as fixing it @alex-zywicki

Have merged your PR and released version 0.4.3.

Unfortunately there is no easy way to catch this in tests. There is already an integration test which asserts that the docs endpoint returns the correct HTML content, however this error is only thrown as part of the JavaScript execution on the client-side. Hence, the only way to properly test this is to execute the returned JavaScript, which feels like an overkill. For now, will have to keep track of this manually, and update the URLs whenever a new version of the specification is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants