Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(costclinear): make multi-dimensional compatible #104

Merged
merged 1 commit into from
Jan 10, 2021

Conversation

oboulant
Copy link
Collaborator

@oboulant oboulant commented Jan 8, 2021

No description provided.

@github-actions github-actions bot added the Type: Fix Bug or Bug fixes label Jan 8, 2021
@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #104 (0c4cd97) into master (577ea32) will increase coverage by 1.57%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   86.68%   88.25%   +1.57%     
==========================================
  Files          41       41              
  Lines         954      954              
==========================================
+ Hits          827      842      +15     
+ Misses        127      112      -15     
Impacted Files Coverage Δ
src/ruptures/costs/costclinear.py 100.00% <100.00%> (+65.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 577ea32...0c4cd97. Read the comment docs.

@deepcharles deepcharles added the Type: Testing Adding missing tests or correcting existing tests label Jan 8, 2021
Copy link
Owner

@deepcharles deepcharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepcharles deepcharles removed the Type: Testing Adding missing tests or correcting existing tests label Jan 8, 2021
@oboulant oboulant merged commit 1ac5f73 into master Jan 10, 2021
@oboulant oboulant deleted the fix-costclinear branch January 10, 2021 13:33
deepcharles added a commit that referenced this pull request Jan 13, 2021
* build: use more recent version of setuptools

* build: automatic versionning using setuptools_scm

* refactor: add version.py to gitignore

This file is generated by setuptools_scm

* ci: use pep517.build to build sdist

* docs: add conda badge

* docs(readme): update installation instructions

* docs: better install instructions

* docs: better install procedure

* refactor: update pre-commit hooks

* refactor: remove requirements-dev.txt

* ci: update all pre-commit hooks

Result of `pre-commit autoupdate`

* style: clean useless comment

* build: cleaner MANIFEST.in

This controls the files that are included in sdist
distributions.

* bug(costclinear): make it mutli-dimensional compatible (#104)

* test(costlinear): add test for CostLinear (#105)

* docs(costlinear): typo

* test(costlinear): add test for CostLinear

* docs: typo

* test(costlinear): Make tests simplier and more integrated

* test(costlinear): typo

* test(costlinear): use simplier np.c_

Co-authored-by: Charles T <charles@doffy.net>

* test: Improve test coverage (#106)

* test(CostMl, CostCosine): Add test, delete duplicate functions, set random seed

* refactor(pw_constant): inject seed for reproducible random state

* test(test_costs): set random seed

* test(test_costs): running black

* test(costlinear): fix an import mishandled by merge with master

* build: change upload-to-pypi gh action 

add an input field in the gh action to override the version number

* ci: install twine before uploading to pypi

* ci: test SETUPTOOLS_SCM_PRETEND_VERSION

* ci: add `with: fetch-depth: 0` to checkout gha

* build: use more recent version of setuptools

* build: automatic versionning using setuptools_scm

* refactor: add version.py to gitignore

This file is generated by setuptools_scm

* ci: use pep517.build to build sdist

* docs: add conda badge

* docs(readme): update installation instructions

* docs: better install instructions

* docs: better install procedure

* refactor: update pre-commit hooks

* refactor: remove requirements-dev.txt

* ci: update all pre-commit hooks

Result of `pre-commit autoupdate`

* style: clean useless comment

* build: cleaner MANIFEST.in

This controls the files that are included in sdist
distributions.

* build: change upload-to-pypi gh action 

add an input field in the gh action to override the version number

* ci: install twine before uploading to pypi

* ci: test SETUPTOOLS_SCM_PRETEND_VERSION

* ci: add `with: fetch-depth: 0` to checkout gha

* ci: cleaner upload to Pypi

Build all wheels and sdist THEN upload to pypi

* ci: remove `check-linting` gha

replaced by the Github app results.pre-commit.ci

* ci: fix gha argument

Co-authored-by: Olivier Boulant <olivier.boulant@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix Bug or Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants