Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use oldest-supported-numpy #114

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Conversation

deepcharles
Copy link
Owner

In pyproject.toml. This way, the oldest numpy version is better managed.

Closes #113

in pyproject.toml. This way, the oldest numpy version is better managed.
@github-actions github-actions bot added the Type: Build Bug fix to a build script label Feb 3, 2021
@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #114 (2662104) into master (faee932) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #114   +/-   ##
=======================================
  Coverage   95.12%   95.12%           
=======================================
  Files          41       41           
  Lines         965      965           
=======================================
  Hits          918      918           
  Misses         47       47           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faee932...2662104. Read the comment docs.

Copy link
Collaborator

@oboulant oboulant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepcharles deepcharles merged commit bf4364a into master Feb 4, 2021
@deepcharles deepcharles deleted the build/pyproject-toml branch February 4, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Build Bug fix to a build script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simpler management of Numpy version depending on OS
2 participants