Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enfoce deepcopy for costar to avoid inplace modifications #164

Merged
merged 1 commit into from
May 26, 2021

Conversation

oboulant
Copy link
Collaborator

@oboulant oboulant commented May 26, 2021

closes #162

@github-actions github-actions bot added the Type: Fix Bug or Bug fixes label May 26, 2021
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #164 (51b0b58) into master (2e6bce6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #164   +/-   ##
=======================================
  Coverage   96.01%   96.02%           
=======================================
  Files          40       40           
  Lines         979      980    +1     
=======================================
+ Hits          940      941    +1     
  Misses         39       39           
Impacted Files Coverage Δ
src/ruptures/costs/costautoregressive.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e6bce6...51b0b58. Read the comment docs.

@oboulant oboulant requested a review from deepcharles May 26, 2021 08:55
@oboulant oboulant merged commit 338e3c1 into master May 26, 2021
@oboulant oboulant deleted the fix-costar-signal-copy branch May 26, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix Bug or Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CostAR modifies signal in-place
2 participants