Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use cibuildwheel package and add tests #210

Merged
merged 4 commits into from
Oct 4, 2021

Conversation

oboulant
Copy link
Collaborator

@oboulant oboulant commented Oct 4, 2021

GHActions supposed to build and upload both the wheels and SDist to Pypi failed (timeout after 6 hours) : https://github.com/deepcharles/ruptures/actions/runs/1291048776 failed

  • Instead of using joerick/cibuildwheel@v1.9.0, we now use the cibuildwheel package directly. It allowed us to get rid of the manual include and exclude in the matrix for the build_wheels job
  • As a bonus, now wheels for Python v3.9 on Windows.
  • We explicitly ask not to build wheels
    • for Python v3.10
    • for PyPy
  • We manually force a version (and avoid building local wheels, the ones with 0.1.dev1 prefix)
  • We added a immediate test of the built wheels (feature offered by cibuildwheel via CIBW_TEST_REQUIRES and CIBW_TEST_COMMAND
  • We switch from actions/checkout@v1 to actions/checkout@v2
  • Removed an incompatible pytest option in pyproject.toml

@github-actions github-actions bot added the Type: Fix Bug or Bug fixes label Oct 4, 2021
@oboulant oboulant added Type: Build Bug fix to a build script Type: CI Changes to CI configuration files and scripts labels Oct 4, 2021
Copy link
Owner

@deepcharles deepcharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

@deepcharles deepcharles merged commit 2128977 into master Oct 4, 2021
@deepcharles deepcharles deleted the ci-fix-build-cibuildwheel branch October 4, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Build Bug fix to a build script Type: CI Changes to CI configuration files and scripts Type: Fix Bug or Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants