Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: better handling of mahalanobis #211

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Conversation

deepcharles
Copy link
Owner

From time to time, test_costs_5D_names fails on CostMl because the random signal has a singular covariance matrix.
When this happens, the test should be skipped. This will not affect coverage since this part of the code is also tested in test_costs_5D_noisy_names.

@deepcharles deepcharles changed the title Test: better handling of mahalanobis test: better handling of mahalanobis Oct 4, 2021
@deepcharles deepcharles added the Type: Testing Adding missing tests or correcting existing tests label Oct 4, 2021
Copy link
Collaborator

@oboulant oboulant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepcharles deepcharles merged commit ef08bf4 into master Oct 4, 2021
@deepcharles deepcharles deleted the test/skip-mahalanobis branch October 4, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Testing Adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants