Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add SignlePnL and OrderId support #131

Merged
merged 7 commits into from
Sep 11, 2024
Merged

feat: Add SignlePnL and OrderId support #131

merged 7 commits into from
Sep 11, 2024

Conversation

Da5hes
Copy link
Contributor

@Da5hes Da5hes commented Sep 10, 2024 •
edited
Loading

  • adding the ability to set OrderId so we can place complex orders i.e bracket order or other parent/child orders
  • adding support to request single position PnL

@Da5hes
- added support for single position PnL
fa205e6 
- added support for defining order Id's to allow complex parent/child orders i.e bracket orders
@Da5hes
fix
a7229c7
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Da5hes Da5hes changed the title Add SignlePnL and OrderId support feat: Add SignlePnL and OrderId support Sep 10, 2024
@Da5hes
Copy link
Contributor Author

Da5hes commented Sep 10, 2024

I have read the CLA Document and I hereby sign the CLA

chipkent
chipkent reviewed Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@chipkent chipkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission. This looks like a good feature.

src/deephaven_ib/_tws/tws_client.py Show resolved Hide resolved
src/deephaven_ib/_tws/tws_client.py Show resolved Hide resolved
src/deephaven_ib/_tws/tws_client.py Show resolved Hide resolved
@Da5hes
Copy link
Contributor Author

Da5hes commented Sep 10, 2024

resolved all comments with latest commit

@Da5hes Da5hes requested a review from chipkent September 10, 2024 20:51
chipkent
chipkent reviewed Sep 11, 2024
View reviewed changes
src/deephaven_ib/__init__.py Outdated Show resolved Hide resolved
src/deephaven_ib/__init__.py Outdated Show resolved Hide resolved
src/deephaven_ib/__init__.py Outdated Show resolved Hide resolved
Da5hes and others added 4 commits September 12, 2024 00:10
@Da5hes @chipkent
Update src/deephaven_ib/__init__.py
effdd2e 
Co-authored-by: Chip Kent <5250374+chipkent@users.noreply.github.com>
@Da5hes @chipkent
Update src/deephaven_ib/__init__.py
c946a51 
Co-authored-by: Chip Kent <5250374+chipkent@users.noreply.github.com>
@Da5hes @chipkent
Update src/deephaven_ib/__init__.py
aa0bfdf 
Co-authored-by: Chip Kent <5250374+chipkent@users.noreply.github.com>
@Da5hes
fix access to contract id
af468aa
@chipkent chipkent merged commit 7840aaf into deephaven-examples:main Sep 11, 2024
7 of 9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
@Da5hes Da5hes deleted the pnlAndOrderid branch September 11, 2024 21:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chipkent chipkent chipkent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Da5hes @chipkent