Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per Benchmark Docker Service Selection #314

Open
stanbrub opened this issue Jul 9, 2024 · 0 comments
Open

Per Benchmark Docker Service Selection #314

stanbrub opened this issue Jul 9, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@stanbrub
Copy link
Collaborator

stanbrub commented Jul 9, 2024

Given that we are adding more services (like MinIO) to the docker-compose.yml for testing, there needs to be a way to select which services are relevant for each benchmark. Rather than having multiple docker compose files that have different combinations of services that somehow must be applied appropriately to benchmarks during the workflow, it's clearer and easier to allow tests to specify which services they will use if they are not using the defaults (e.g. deephaven, redpanda)

  • Add a String...services to the restart commands to allow selection of services
  • Add a method to the few test runners to allow the user to set a service list in the setup portion of the test
  • Add the services to `docker compose up ..." as allowed by the docker specification
    • ex. docker compose up -d deephaven redpanda works in testing
  • Ensure that all services in the docker compose work together when all are selected
@stanbrub stanbrub added the enhancement New feature or request label Jul 9, 2024
@stanbrub stanbrub self-assigned this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant