Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Benchmark Tests on a Given Branch #92

Closed
stanbrub opened this issue Apr 27, 2023 · 2 comments · Fixed by #275
Closed

Run Benchmark Tests on a Given Branch #92

stanbrub opened this issue Apr 27, 2023 · 2 comments · Fixed by #275
Labels
enhancement New feature or request

Comments

@stanbrub
Copy link
Collaborator

High Level Problem

  • Developer makes improvements on a branch to an existing DH operation (e.g. where)
  • Developer wants to compare benchmarks for changes against existing nightly benchmarks
  • For consistency, run benchmarks on the same server as the nightly builds

Questions

  • Is this done in an adhoc way, without preserving the results?
  • Since nightly is done against docker, how do we do a proper comparison to the branch?
  • How automated is this? Do it from a github workflow?
@stanbrub stanbrub added the enhancement New feature or request label Apr 27, 2023
@devinrsmith
Copy link
Member

Yeah - the use-case is that we might want to have benchmarks as one of the deciding factors for deephaven-core PR approval (not necessarily for all PRs, but those specifically touting to be operational improvements that we should be able to benchmark).

It's easy enough for me to do ad-hoc "benchmarking" locally, but it would be nice if there was an official way.

@stanbrub
Copy link
Collaborator Author

stanbrub commented May 1, 2023

So it sounds like this would be something driven by a github workflow. And we'd have to figure out things like how to make sure two tests don't run on the benchmark system or add bare metal provisioning into the workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants