web UI not allowing panels to be resized

[devinrsmith]

PR #3049 seems to have broken my ability to resize panels in the web UI. web console logs showing "TouchEvent is not defined"

Easy to reproduce in main, ./gradlew server-jetty-app:run -Pgroovy, open web ui, create notebook if none open, try to resize.

May also be able to reproduce like:

docker pull ghcr.io/deephaven/server:edge
docker run --rm -p 10000:10000 ghcr.io/deephaven/server:edge

[mofojed]

Reproducible in FireFox 106.0.3, not reproducible in Chrome. Almost certainly caused by converting golden-layout to TS: deephaven/web-client-ui#796

Uncaught ReferenceError: TouchEvent is not defined
    _getCoordinates DragListener.ts:136
    onMouseDown DragListener.ts:66
    jQuery 2
DragListener.ts:136:6

[mofojed]

Before conversion the _getCoordinates function was:

  _getCoordinates: function (event) {
    event =
      event.originalEvent && event.originalEvent.touches
        ? event.originalEvent.touches[0]
        : event;
    return {
      x: event.pageX,
      y: event.pageY,
    };
  },

After conversion, it is:

  _getCoordinates(event: JQuery.TriggeredEvent) {
    const baseEvent =
      event.originalEvent instanceof TouchEvent
        ? event.originalEvent.touches[0]
        : event;
    return {
      x: baseEvent.pageX,
      y: baseEvent.pageY,
    };
  }

According to caniuse, TouchEvent should be available in FireFox: https://caniuse.com/?search=touchevent
However, it looks like it's also not supported in Safari, so should rip it out anyway.

[mofojed]

Seems like TouchEvent may only be defined on FireFox mobile: https://bugzilla.mozilla.org/show_bug.cgi?id=1693172
Either way it's not defined, we only use it in two places so just fix that.

As mentioned on https://developer.mozilla.org/en-US/docs/Web/API/Touch_events#example:

Touch events are typically available on devices with a touch screen, but many browsers make the touch events API unavailable on all desktop devices, even those with touch screens.

The reason for this is that some websites use the availability of parts of the touch events API as an indicator that the browser is running on a mobile device. If the touch events API is available, these websites will assume a mobile device and serve mobile-optimized content. This may then provide a poor experience for users of desktop devices that have touch screens.

[mofojed]

PR for web-client-ui posted: deephaven/web-client-ui#868