Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server should validate that deephaven:type and arrow type match #3403

Open
niloc132 opened this issue Feb 3, 2023 · 0 comments · May be fixed by #6065
Open

Server should validate that deephaven:type and arrow type match #3403

niloc132 opened this issue Feb 3, 2023 · 0 comments · May be fixed by #6065
Labels

Comments

@niloc132
Copy link
Member

niloc132 commented Feb 3, 2023

Historically, Deephaven would accept arrow int8 columns for boolean values, to be able to track true/false/null. That has changed on the server, and for a time the server did not validate that a client would correctly send individual bits instead of bytes for each value. This has been changed by #3401.

However, the other custom deephaven:type mappings should also be validated, to ensure they are being sent as the expected arrow type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant