Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API method calling restrictions need to be more configurable #5699

Open
rbasralian opened this issue Jun 28, 2024 · 0 comments
Open

API method calling restrictions need to be more configurable #5699

rbasralian opened this issue Jun 28, 2024 · 0 comments
Assignees
Labels
feature request New feature or request triage
Milestone

Comments

@rbasralian
Copy link
Contributor

We need to make some changes to the io.deephaven.server.table.validation.ColumnExpressionValidator:

  1. The class/method whitelists need to be configurable on the server
  2. We need to support package-level whitelisting
  3. If a user is allowed to run executeCode() through the API, then the ColumnExpressionValidator should be skipped for their API calls as well. (Otherwise we're just inconveniencing them without providing any security benefit.) As part of this, we should probably also disable the ability to run executeCode() by default. (So locked-down by default, but easy to add to the whitelist or to open up entirely.)

It should also be possible to have different whitelists/permissions depending on the client (e.g. by user for enterprise), but that's potentially a separate issue.

@rbasralian rbasralian added feature request New feature or request triage labels Jun 28, 2024
@devinrsmith devinrsmith added this to the 3. Triage milestone Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request triage
Projects
None yet
Development

No branches or pull requests

3 participants