Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: statistical functions should return null when provided a vector of only null values #239

Closed
deephaven-internal opened this issue Jun 19, 2024 · 2 comments

Comments

@deephaven-internal
Copy link

This issue was auto-generated

PR: deephaven/deephaven-core#5606
Author: lbooker42

Original PR Body

Updated Numeric functions and tests:

  • avg
  • absAvg
  • var
  • wvar
  • std
  • wstd
  • ste
  • wste
  • tstat
  • wtstat
  • median - had incorrect behavior when null values present
  • percentile - had incorrect behavior when null values present
  • cov
  • cor

Updated UpdateBy aggregations and tests:

  • RollingAvg
  • RollingStd

Updated AggBy aggregations:

  • avg
  • var
  • std
  • ReVar
  • ReAvg

Will close #5564

@jjbrosnan
Copy link

I don't think this ticket warrants any actual docs work. It fixes null handling behavior of several statistical functions, and is related to tickets that widened return types.

The new null handling behavior is what users should expect to happen, and should not require any discussion in documentation.

@alexpeters1208
Copy link

I looked around in the docs and I agree - no work needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants