Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ui.image #597

Closed
mofojed opened this issue Jul 2, 2024 · 2 comments · Fixed by #670
Closed

Add support for ui.image #597

mofojed opened this issue Jul 2, 2024 · 2 comments · Fixed by #670
Assignees
@ethanalvizo
Labels
enhancement New feature or request

Comments

@mofojed
Copy link
Member

mofojed commented Jul 2, 2024 •
edited

Add support for ui.image in deephaven.ui: https://react-spectrum.adobe.com/react-spectrum/Image.html. We already support ui.html.img, but ui.image should produce better defaults for size.
@mofojed mofojed added enhancement New feature or request triage labels Jul 2, 2024
@mofojed mofojed removed the triage label Jul 4, 2024
@mofojed
Copy link
Member Author

mofojed commented Jul 4, 2024

Take a look at how RadioGroup was added in this PR: https://github.com/deephaven/deephaven-plugins/pull/512/files

@mofojed
Copy link
Member Author

mofojed commented Jul 4, 2024

Add pydocs at the same time

@ethanalvizo ethanalvizo mentioned this issue Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanalvizo ethanalvizo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: ui.image ethanalvizo/deephaven-plugins
2 participants
@mofojed @ethanalvizo