Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeephavenColor and StaticColor types are incorrect #600

Closed
mofojed opened this issue Jul 4, 2024 · 0 comments · Fixed by #647
Closed

DeephavenColor and StaticColor types are incorrect #600

mofojed opened this issue Jul 4, 2024 · 0 comments · Fixed by #647
Assignees
@ethanalvizo
Labels
bug Something isn't working

Comments

@mofojed
Copy link
Member

mofojed commented Jul 4, 2024

DeephavenColor only has salmon and lemonchiffon:

deephaven-plugins/plugins/ui/src/deephaven/ui/types/types.py

Line 224 in 1623ff5

DeephavenColor = Literal["salmon", "lemonchiffon"]

That type should have all the values defined in our colorUtils: https://github.com/deephaven/web-client-ui/blob/a11e2ceaf216d640068562a05fdb156c69481d47/packages/components/src/theme/colorUtils.ts#L6
Also StaticColor is used in many spots where Color should be used instead - StaticColor should only be used for static_color props.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanalvizo ethanalvizo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: color type ethanalvizo/deephaven-plugins
2 participants
@mofojed @ethanalvizo