New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce typescript types in CI builds #618

Open

bmingles opened this issue Jul 10, 2024 · 0 comments

Labels

Milestone

Contributor

bmingles commented Jul 10, 2024 •

edited

Loading

Our CI builds don't currently fail CI builds based on TypeScript type checks. We should:

Fix current typescript errors in js plugins (should probably upgrade @deephaven/jsapi-types to 1.0.0-dev versions if possible)

Note that refactor: Improve GL item config types web-client-ui#2138 should fix remaining type errors in ui plugin)
Run type checks as part of CI and fail the build if there are type errors

The text was updated successfully, but these errors were encountered:

bmingles added enhancement triage labels

vbabich added this to the August 2024 milestone

vbabich removed the triage label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment