Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Icons for vscode-deephaven extension #13

Open
bmingles opened this issue Jun 26, 2024 · 2 comments
Open

Additional Icons for vscode-deephaven extension #13

bmingles opened this issue Jun 26, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@bmingles
Copy link
Collaborator

bmingles commented Jun 26, 2024

The vscode-deephaven extension could use a few additional icons

  • Differentiate connected vs disconnected. Default product icons only include this one
    image
  • Better run icons for "Run Deephaven File" vs "Run Deephaven Selected Lines" (currently using $(run-all) and
    $(run) icons) which are shared by other commands such as the Python extension one
  • Blank icon the same size as other product icons. This will help for things like our connection selector where we use icons to indicate the active connection but have to hack leading spaces to match indentation for the disconnected server names Looks like codicons already has $(blank). Guess I missed it before.
  • Others?

Vscode extensions have an icons contribution point where a font icon font (.woff) can provide additional icons.
https://code.visualstudio.com/api/references/icons-in-labels#icon-contribution-point

UPDATE: Here's what things currently look like:
Status bar states
image

Quick pick menu states
image

Run Buttons
"Run Deephaven File" and "Run Deephaven Selected Lines" respectively
image

@bmingles bmingles added enhancement New feature or request triage labels Jun 26, 2024
@mofojed mofojed removed the triage label Jun 27, 2024
@mofojed
Copy link
Member

mofojed commented Jun 27, 2024

Maybe the Deephaven D should be shown there when connected? Similar to the GitHub Copilot icon being displayed when it is connected.

@mofojed mofojed changed the title Additional Icons Additional Icons for vscode-deephaven extension Jul 8, 2024
@bmingles bmingles added this to the July 2024 milestone Jul 8, 2024
@bmingles
Copy link
Collaborator Author

@dsmmcken I just noticed a clause in vscode publishing docs regarding SVG images:

Note: Due to security concerns, vsce will not publish extensions that contain user-provided SVG images.

https://code.visualstudio.com/api/working-with-extensions/publishing-extension#publishing-extensions

Not 100% sure yet how this impacts custom icon fonts.

@mofojed mofojed removed this from the July 2024 milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants