From fbe1e70135008db293878368ad62f742b8166e19 Mon Sep 17 00:00:00 2001
From: Matthew Runyon <matthewrunyon@deephaven.io>
Date: Tue, 24 Oct 2023 13:18:11 -0500
Subject: [PATCH] fix: Tab in console input triggers autocomplete instead of
 indent (#1591)

In the console, pressing the `Tab` key previously brought up the
autocomplete prompt. Now it will insert a tab's worth of spaces instead.

Can still trigger autocomplete by using `Ctrl+Space`
---
 packages/console/src/ConsoleInput.tsx | 36 ++++++++-------------------
 1 file changed, 11 insertions(+), 25 deletions(-)

diff --git a/packages/console/src/ConsoleInput.tsx b/packages/console/src/ConsoleInput.tsx
index 552dd44492..a6066f5f5f 100644
--- a/packages/console/src/ConsoleInput.tsx
+++ b/packages/console/src/ConsoleInput.tsx
@@ -180,7 +180,6 @@ export class ConsoleInput extends PureComponent<
         top: TOP_PADDING,
         bottom: BOTTOM_PADDING,
       },
-      tabCompletion: 'on',
       value: '',
       wordWrap: 'on',
     } as const;
@@ -255,30 +254,17 @@ export class ConsoleInput extends PureComponent<
       }
 
       if (!keyEvent.altKey && !keyEvent.shiftKey && !keyEvent.metaKey) {
-        if (keyEvent.keyCode === monaco.KeyCode.Enter) {
-          if (!this.isSuggestionMenuPopulated()) {
-            keyEvent.stopPropagation();
-            keyEvent.preventDefault();
-
-            const command = this.commandEditor?.getValue().trim();
-            if (command !== undefined) {
-              this.processCommand(command);
-              this.commandEditor?.setValue('');
-            }
-          }
-        } else if (keyEvent.keyCode === monaco.KeyCode.Tab) {
-          if (!this.isSuggestionMenuActive()) {
-            keyEvent.stopPropagation();
-            keyEvent.preventDefault();
-
-            this.commandEditor?.trigger(
-              'Tab key trigger suggestions',
-              'editor.action.triggerSuggest',
-              {}
-            );
-          } else if (!this.isSuggestionMenuPopulated()) {
-            keyEvent.stopPropagation();
-            keyEvent.preventDefault();
+        if (
+          keyEvent.keyCode === monaco.KeyCode.Enter &&
+          !this.isSuggestionMenuPopulated()
+        ) {
+          keyEvent.stopPropagation();
+          keyEvent.preventDefault();
+
+          const command = this.commandEditor?.getValue().trim();
+          if (command !== undefined) {
+            this.processCommand(command);
+            this.commandEditor?.setValue('');
           }
         }
       }