Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable "Changes you made may not be saved." prompt in dev mode #1775

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

dsmmcken
Copy link
Contributor

@dsmmcken dsmmcken commented Feb 6, 2024

When developing, the prompt to reload is a pretty annoying feature. I am not worried about lost query progress in dev mode, auto-refresh is more important.

When developing this is a pretty annoying feature. I am not worried about lost query progress, auto-refresh is more important.
@dsmmcken dsmmcken changed the title Dmckenzie_conditional_prompt feat: disable "Changes you made may not be saved." prompt in dev mode Feb 6, 2024
@dsmmcken dsmmcken requested a review from mofojed February 6, 2024 15:44
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2cd46ce) 46.10% compared to head (0e0d515) 46.10%.
Report is 1 commits behind head on main.

Files Patch % Lines
packages/code-studio/src/main/AppMainContainer.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1775      +/-   ##
==========================================
- Coverage   46.10%   46.10%   -0.01%     
==========================================
  Files         627      627              
  Lines       37622    37623       +1     
  Branches     9470     9471       +1     
==========================================
  Hits        17345    17345              
- Misses      20222    20223       +1     
  Partials       55       55              
Flag Coverage Δ
unit 46.10% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsmmcken dsmmcken merged commit 6b0dce1 into main Feb 6, 2024
7 of 8 checks passed
@dsmmcken dsmmcken deleted the dmckenzie_conditional_prompt branch February 6, 2024 16:41
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2024
@dsmmcken dsmmcken self-assigned this Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants